You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
The simple types: Topic, Partition, Position are all cloned when being moved around the different layers of the library.
This is mostly not useful. Topics should have a static lifetime and passed by reference, Partition and Position should be owned by a consumer between one assignment and another and really may need to be cloned only when returning a message.
This means revisiting all the places where we pass and receive those structs and consider passing only references around instead of copying everything.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The simple types: Topic, Partition, Position are all cloned when being moved around the different layers of the library.
This is mostly not useful. Topics should have a static lifetime and passed by reference, Partition and Position should be owned by a consumer between one assignment and another and really may need to be cloned only when returning a message.
This means revisiting all the places where we pass and receive those structs and consider passing only references around instead of copying everything.
The text was updated successfully, but these errors were encountered: