Add biome for lint and format

Author: timfish

.prettierrc

@@ -0,0 +1,31 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
+  "vcs": { "enabled": false, "clientKind": "git", "useIgnoreFile": false },
+  "files": { "ignoreUnknown": false, "ignore": ["dist/*"] },
+  "formatter": {
+    "enabled": true,
+    "useEditorconfig": true,
+    "formatWithErrors": false,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineEnding": "lf",
+    "lineWidth": 120,
+    "attributePosition": "auto",
+    "bracketSpacing": true
+  },
+  "organizeImports": { "enabled": true },
+  "linter": { "enabled": true, "rules": { "recommended": true } },
+  "javascript": {
+    "formatter": {
+      "jsxQuoteStyle": "double",
+      "quoteProperties": "asNeeded",
+      "trailingCommas": "all",
+      "semicolons": "always",
+      "arrowParentheses": "always",
+      "bracketSameLine": false,
+      "quoteStyle": "single",
+      "attributePosition": "auto",
+      "bracketSpacing": true
+    }
+  }
+}

biome.json

@@ -6,17 +6,17 @@
   "scripts": {
     "build": "rollup --config rollup.config.mjs",
     "test": "vitest run ./test/src/**/*.test.ts",
-    "lint": "prettier --check \"{packages,test}/**/*.{js,ts}\"",
-    "fix": "prettier --write \"{packages,test}/**/*.{js,ts}\""
+    "lint": "biome check",
+    "fix": "biome check --write"
   },
   "devDependencies": {
-    "@rollup/plugin-typescript": "^12.1.0",
+    "@biomejs/biome": "1.9.3",
     "@rollup/plugin-node-resolve": "^15.3.0",
+    "@rollup/plugin-typescript": "^12.1.0",
     "@rspack/cli": "^1.0.8",
     "@rspack/core": "^1.0.8",
     "@types/node": "^20.0.0",
     "esbuild": "^0.24.0",
-    "prettier": "^3.3.3",
     "parcel": "^2.12.0",
     "rolldown": "^0.13.2",
     "rollup": "^4.22.5",
@@ -26,10 +26,7 @@
     "webpack": "^5.95.0",
     "webpack-cli": "^5.1.4"
   },
-  "workspaces": [
-    "packages/*",
-    "test"
-  ],
+  "workspaces": ["packages/*", "test"],
   "volta": {
     "node": "20.18.0",
     "yarn": "1.22.22"

package.json

@@ -1,5 +1,5 @@
-import { readFile, writeFile } from 'fs/promises';
-import { addDebugIdToSource, stringToUUID, addDebugIdToSourcemap, walk, DEFAULT_EXTENSIONS } from '@debugids/common';
+import { readFile, writeFile } from 'node:fs/promises';
+import { DEFAULT_EXTENSIONS, addDebugIdToSource, addDebugIdToSourcemap, stringToUUID, walk } from '@debugids/common';
 
 async function groupSourceAndMapFiles(files: string[]): Promise<Array<[string, string | undefined]>> {
   const sourceFiles = files.filter((f) => !f.endsWith('.map'));
@@ -21,8 +21,8 @@ async function groupSourceAndMapFiles(files: string[]): Promise<Array<[string, s
   const extensions = [...DEFAULT_EXTENSIONS, ...DEFAULT_EXTENSIONS.map((e) => `${e}.map`)];
   const results = await walk(process.argv[2], extensions);
   const groupedResults = await groupSourceAndMapFiles(results);
-  let modifiedFiles: Array<{ source: string; map: string; debugId: string }> = [];
-  let missingMaps = new Set<string>();
+  const modifiedFiles: Array<{ source: string; map: string; debugId: string }> = [];
+  const missingMaps = new Set<string>();
   let addedDebugIds = 0;
 
   const promises = groupedResults.map(async ([source, map]) => {

packages/cli/src/index.ts

@@ -1,6 +1,6 @@
-import * as crypto from 'crypto';
-import { opendir } from 'fs/promises';
-import { join } from 'path';
+import * as crypto from 'node:crypto';
+import { opendir } from 'node:fs/promises';
+import { join } from 'node:path';
 
 export const DEFAULT_EXTENSIONS = ['.js', '.mjs', '.cjs'];
 
@@ -13,18 +13,7 @@ export function stringToUUID(str: string): string {
   // RFC 4122 section 4.4
   const v4variant = ['8', '9', 'a', 'b'][md5Hash.substring(16, 17).charCodeAt(0) % 4] as string;
 
-  return (
-    md5Hash.substring(0, 8) +
-    '-' +
-    md5Hash.substring(8, 12) +
-    '-4' +
-    md5Hash.substring(13, 16) +
-    '-' +
-    v4variant +
-    md5Hash.substring(17, 20) +
-    '-' +
-    md5Hash.substring(20)
-  ).toLowerCase();
+  return `${md5Hash.substring(0, 8)}-${md5Hash.substring(8, 12)}-4${md5Hash.substring(13, 16)}-${v4variant}${md5Hash.substring(17, 20)}-${md5Hash.substring(20)}`.toLowerCase();
 }
 
 export function addDebugIdToSource(input: string, debugId: string): string {
@@ -45,7 +34,7 @@ export function getDebugIdFromString(input: string): string | undefined {
 }
 
 export async function walk(path: string, extensions: string[]): Promise<string[]> {
-  let files = [];
+  const files = [];
 
   for await (const file of await opendir(path)) {
     if (file.isDirectory()) {

packages/common/src/index.ts

@@ -1,7 +1,7 @@
+import { readFile, writeFile } from 'node:fs/promises';
+import * as path from 'node:path';
+import { DEFAULT_EXTENSIONS, addDebugIdToSource, addDebugIdToSourcemap, stringToUUID } from '@debugids/common';
 import type { PluginBuild } from 'esbuild';
-import { addDebugIdToSource, DEFAULT_EXTENSIONS, stringToUUID, addDebugIdToSourcemap } from '@debugids/common';
-import { readFile, writeFile } from 'fs/promises';
-import * as path from 'path';
 
 export default {
   name: 'esbuild-plugin-debug-ids',

packages/esbuild/src/index.ts

@@ -1,4 +1,4 @@
-import * as fs from 'fs/promises';
+import * as fs from 'node:fs/promises';
 import { getDebugIdFromString } from '@debugids/common';
 
 async function getLastBytesFromFile(path: string, bytesToRead = 1024) {

packages/node/src/index.ts

@@ -1,5 +1,5 @@
+import { addDebugIdToSource, stringToUUID } from '@debugids/common';
 import { Optimizer } from '@parcel/plugin';
-import { stringToUUID, addDebugIdToSource } from '@debugids/common';
 
 export default new Optimizer({
   async optimize({ contents, map }) {
@@ -15,12 +15,13 @@ export default new Optimizer({
     // the only way I could find to add the debugId to the sourcemap is to proxy
     // the map 'toVLQ()' method to add the debugId to the sourcemap object...
     const proxiedMap = new Proxy(map, {
-      get: function (target, prop, receiver) {
+      get: (target, prop, receiver) => {
         if (prop === 'toVLQ') {
           const original = Reflect.get(target, prop, receiver);
 
           return function toVLQ(this: unknown) {
             const result = original.apply(this);
+            // biome-ignore lint/suspicious/noExplicitAny: We're adding a debugId to the sourcemap
             (result as any).debugId = debugId;
             return result;
           };

packages/parcel/src/index.ts

@@ -1,6 +1,6 @@
+import { TextDecoder } from 'node:util';
+import { DEFAULT_EXTENSIONS, addDebugIdToSource, addDebugIdToSourcemap, stringToUUID } from '@debugids/common';
 import type { OutputAsset, OutputChunk, Plugin } from 'rollup';
-import { addDebugIdToSourcemap, addDebugIdToSource, stringToUUID, DEFAULT_EXTENSIONS } from '@debugids/common';
-import { TextDecoder } from 'util';
 
 function getString(input: string | Uint8Array): string {
   if (typeof input === 'string') {
@@ -13,7 +13,7 @@ function getString(input: string | Uint8Array): string {
 export default function debugIds(): Plugin {
   return {
     name: 'rollup-plugin-debug-ids',
-    generateBundle: function (_, bundle: { [fileName: string]: OutputAsset | OutputChunk }) {
+    generateBundle: (_, bundle: { [fileName: string]: OutputAsset | OutputChunk }) => {
       for (const [key, value] of Object.entries(bundle)) {
         // We only add debugId where there is a linked sourcemap file
         if (!('sourcemapFileName' in value) || !value.sourcemapFileName) {
@@ -38,8 +38,9 @@ export default function debugIds(): Plugin {
         // vite has a plugin that runs after us which can modify the sourcemap so we
         // proxy the sourceMapFile to re-add the debugId if the source gets set again
         bundle[value.sourcemapFileName] = new Proxy(bundle[value.sourcemapFileName] as OutputAsset, {
-          set: function <K extends keyof OutputAsset>(target: OutputAsset, prop: K, value: OutputAsset[K]) {
+          set: <K extends keyof OutputAsset>(target: OutputAsset, prop: K, value: OutputAsset[K]) => {
             if (prop === 'source') {
+              // biome-ignore lint/suspicious/noExplicitAny: Can't get types to work here
               (target as any)[prop] = addDebugIdToSourcemap(getString(value as string | Uint8Array), debugId);
             } else {
               target[prop] = value;

packages/rollup/src/index.ts

@@ -1,5 +1,5 @@
+import { DEFAULT_EXTENSIONS, addDebugIdToSource, addDebugIdToSourcemap, stringToUUID } from '@debugids/common';
 import type { Compiler } from 'webpack';
-import { DEFAULT_EXTENSIONS, addDebugIdToSource, stringToUUID, addDebugIdToSourcemap } from '@debugids/common';
 
 const PLUGIN_NAME = 'DebugIdWebpackPlugin';