Adding back button in settings activity #369
Conversation
There was a problem hiding this comment.
Thanks for sending PR @htg2704, I just gave some suggestion
please run ./gradlew checkcode locally so, you will get a detailed explanation of where you are getting an error
| @Override | ||
| public void onClick(View v) { | ||
| try { | ||
| Intent intent = new Intent(SettingsActivity.this, MainActivity.class); |
There was a problem hiding this comment.
You are giving intent here, it is not actually the good practice because if the user click back once again it will come to settingsActivity
please try this
toolbar.setNavigationIcon(getResources().getDrawable(R.drawable.back_arrow));
toolbar.setNavigationOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
onBackPressed();
}
});
| android:configChanges="orientation|screenSize" | ||
| android:parentActivityName=".views.ui.send.SendFormsActivity" | ||
| > | ||
| <meta-data |
There was a problem hiding this comment.
No need to add metadata for this change
There was a problem hiding this comment.
I can understand that, can you rephrase that
There was a problem hiding this comment.
Removed configChanges for now. It wasn,t needed for this commit.
There was a problem hiding this comment.
I still can see in the file changes can you please check that
There was a problem hiding this comment.
it's not there for me, shall I send a new pr?
There was a problem hiding this comment.
No need to do new PR you still can work on this
There was a problem hiding this comment.
please run ./gradlew checkcode locally
|
|
||
| addPreferencesFromResource(R.xml.preferences_menu); | ||
| addPreferences(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean onOptionsItemSelected(MenuItem item) { | ||
| if (item.getItemId() == android.R.id.home) { |
There was a problem hiding this comment.
why did you removed this
| @@ -244,6 +258,5 @@ public void afterTextChanged(Editable s) { | |||
| alertDialog.setCancelable(true); | |||
| alertDialog.getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); | |||
| } | |||
|
|
|||
| @@ -45,7 +46,11 @@ | |||
| android:value=".views.ui.main.MainActivity" /> | |||
| </activity> | |||
| <activity android:name=".views.ui.instance.InstancesList" /> | |||
| <activity android:name=".views.ui.settings.SettingsActivity" /> | |||
| <activity android:name=".views.ui.settings.SettingsActivity" | |||
There was a problem hiding this comment.
revert whatever changes you did in manifest file, as there is no need
Closes #367
What has been done to verify that this works as intended?
Checked on physical device
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Creates better user experience
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes