[v1.30.2] aws-cdk-lib.aws_cloudfront_origins.S3Origin is deprecated

[shengslogar]

Description

Low priority "bug".

When deploying a Serverless v3 app with this plugin installed, multiple duplicate console warnings are displayed:

[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.

I only use server-side-website asset splitting, which would require S3Origin to be replaced with S3BucketOrigin. Not sure about all the other possible use cases.

How to Reproduce

Set up a project following the "Server-side website" README and run sls package or sls deploy.

Additional Information

• Serverless Framework v3.39.0
• Lift v1.30.2

[seriquynh]

I'm using v1.30.3 and see the following deprecations.

[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin#bind is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin#bind is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_cloudfront_origins.S3Origin#bind is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.

Are there any updates about resolving these deprecations?

[mnapoli]

@seriquynh a pull request would be welcome 👍

[seriquynh]

@mnapoli I'm sorry for the late reply.

I don't have much experience working with AWS or Serverless. I'm also completely new to Bref and the Serverless Lift plugin. I tried researching ways I might be able to help, but unfortunately, I couldn't find anything.

First, I noticed that the repository or the plugin page doesn't have a CONTRIBUTING section. Next, I looked at the CI workflow to understand how the tests were executed. It didn't seem to have any special configurations. If the Serverless version was 2, we would need to use @serverless/test@8. Otherwise, it could be left as is.

Here is my environment:

• OS: Windows 11 Pro
• Node: v20.17.0
• NPM: 10.9.2

After cloning the repository, I ran npm install, followed by npm run test. But, many tests failed due to errors I have no idea for now.

Depending on deprecations, I guess replacing S3Origin with S3BucketOrigin like this file.

The key is I don't know how to verify if it works after replacing.

So, could you guide me how to run tests, how it works, please? Or point me to the right CONTRIBUTING place?

[mnapoli]

@seriquynh thank you for looking into this.

I think it's perfectly fine to wait for someone with more experience with the CDK to dive into this to be honest. The class is deprecated but nothing is broken, we have more time until this becomes more urgent.