Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writer toolbar: hide when no buttons #6846

Open
wants to merge 1 commit into
base: develop-patch
Choose a base branch
from
Open

Writer toolbar: hide when no buttons #6846

wants to merge 1 commit into from
+2 −3

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Dec 7, 2024 •
edited
Loading

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Dec 7, 2024
@distantnative distantnative added this to the 4.6.0 milestone Dec 7, 2024
@distantnative distantnative requested a review from a team December 7, 2024 18:22
@distantnative distantnative self-assigned this Dec 7, 2024
@distantnative distantnative marked this pull request as ready for review December 7, 2024 18:27
@distantnative distantnative linked an issue Dec 7, 2024 that may be closed by this pull request
Writer Fields Non-inline toolbar should not show when no marks or nodes are available #6804
Open
afbora
afbora approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@afbora afbora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the target branch be develop-minor for 4.6.0?

@distantnative
Copy link
Member Author

@afbora not necessarily. We put everything that could be released in a patch release on develop-patch - in that case that we would want to release a 4.5.1, we could do that right away with the necessary changes already on develop-patch. Since we continuously merge develop-patch into develop-minor, if we decide against any patch release, they're automatically included in the next minor release.

@distantnative distantnative mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbora afbora afbora approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Writer Fields Non-inline toolbar should not show when no marks or nodes are available
2 participants
@distantnative @afbora