Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloatShield: VL53L0X pololu library update #194

Closed
PeterChmurciak opened this issue Oct 30, 2019 · 5 comments
Closed

FloatShield: VL53L0X pololu library update #194

PeterChmurciak opened this issue Oct 30, 2019 · 5 comments
Labels
enhancement New feature or request feature_request float FloatShield functionality question

Comments

@PeterChmurciak
Copy link
Contributor

@gergelytakacs The issue thread for this topic was already closed and I did not want to spam other threads with it.

The pololu guys have recently updated their library and also have pulled in our request for submodule functionality. That means we can now use the "official" library as a git submodule for our VL53L0X laser sensor. It would again require some git command kung-fu to swap the used sumbodules, but it would provide an "regularly" (or at least sometimes) updated library for the sensor. Just wanted to let you know that there is this option now.

@PeterChmurciak PeterChmurciak added enhancement New feature or request float FloatShield functionality question labels Oct 30, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@gergelytakacs
Copy link
Owner

Thank you for the heads up! This is good news. Have you tested the updated library by any chance?

And by the way, congrats to improving the Polulu library:)

@PeterChmurciak
Copy link
Contributor Author

@gergelytakacs Well, thanks :). There have been only minor changes but to make sure I have tested the IDE examples and they work as they should - so we can update it if we want to. The Matlab and Simulink library counterparts use their own library files, and would need to be updated manually, which is not worth doing right now, considering there have been only minor changes in the library files.

@gergelytakacs
Copy link
Owner

Thank you for the heads up and confirming that their update works.

I will leave this issue open with the hope that I will be in the mood to do said Git kung-fu, but right now I lack the mental capacity. If you wish, you may do it yourself, in other case let's leave this issue open.

@gergelytakacs
Copy link
Owner

Closed and cancelled because of the need to account for SAM boards as per the suggestion of @PeterChmurciak in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature_request float FloatShield functionality question
Projects
None yet
Development

No branches or pull requests

2 participants