Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COUNT(*) does not work as expected #1170

Closed
2 tasks done
pchunduri6 opened this issue Sep 19, 2023 · 3 comments · Fixed by #1376
Closed
2 tasks done

COUNT(*) does not work as expected #1170

pchunduri6 opened this issue Sep 19, 2023 · 3 comments · Fixed by #1376
Assignees
@jkim3663
Labels
Bug 🐞 EVA is not working as expected
Milestone
V0.3.10

Comments

@pchunduri6
Copy link
Contributor

pchunduri6 commented Sep 19, 2023 •
edited
Loading

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

COUNT(*) throws an invalid column id error.
image

Environment

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@pchunduri6 pchunduri6 added the Bug 🐞 EVA is not working as expected label Sep 19, 2023
@pchunduri6 pchunduri6 self-assigned this Sep 21, 2023
@xzdandy xzdandy added this to the v0.3.7 milestone Sep 22, 2023
@xzdandy xzdandy removed this from the v0.3.7 milestone Sep 30, 2023
@jkim3663
Copy link
Contributor

Hello, I am planning to take this issue if no one is currently working on it for 4420 evadb project. Thanks!

@jkim3663 jkim3663 mentioned this issue Nov 17, 2023
Open
2 tasks
@pchunduri6 pchunduri6 assigned jkim3663 and unassigned pchunduri6 Nov 17, 2023
@pchunduri6
Copy link
Contributor Author

@jkim3663 sounds good, thanks!

@jkim3663 jkim3663 mentioned this issue Nov 20, 2023
Merged
@xzdandy xzdandy linked a pull request Nov 21, 2023 that will close this issue
Fix COUNT(*) ERROR for PDF SELECT Queries #1376
Merged
@xzdandy xzdandy added this to the V0.3.10 milestone Nov 21, 2023
@jkim3663
Copy link
Contributor

jkim3663 commented Nov 21, 2023 •
edited
Loading

@xzdandy @pchunduri6 Hey everyone, I just wanted to note that COUNT(*) was creating BindingError even without the GROUP BY. E.g., "SELECT COUNT(*) FROM MyPDFs;" was also causing error, but now it is resolved. I'll update my PR's name to be more generic to also reflect this fix.

xzdandy pushed a commit that referenced this issue Nov 22, 2023
@jkim3663
Fix COUNT(*) ERROR for PDF SELECT Queries (#1376)
3d0b647 
#1170

COUNT(*) did not work with GROUP BY, while COUNT(column_name), or
COUNT(SEGMENT(sth)) worked with group by.
The issue was due to wrong column name assingment while creating a tuple
value expression.

I added a test case and a sample pdf that is same as the one from the
issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkim3663 jkim3663

Labels
Bug 🐞 EVA is not working as expected
Projects
EVA Public Roadmap ⚡🚀
Status: Done
Milestone
V0.3.10
Development

Successfully merging a pull request may close this issue.

Fix COUNT(*) ERROR for PDF SELECT Queries jkim3663/evadb
3 participants
@xzdandy @pchunduri6 @jkim3663