Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue refactoring of API #1405 in remaining files #1840

Open
totycro opened this issue Nov 4, 2024 · 0 comments
Open

Continue refactoring of API #1405 in remaining files #1840

totycro opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@totycro
Copy link
Contributor

totycro commented Nov 4, 2024

The api refactoring #1405 introduced a new way of writing APIs. The following two files have not been transformed yet since the change set was already massive:
https://github.com/geopython/pygeoapi/blob/master/pygeoapi/api/__init__.py#L689
https://github.com/geopython/pygeoapi/blob/master/pygeoapi/admin.py#L160%7C

As mentioned in this comment in the review of the PR, these should now be addressed: #1405 (comment)

Transforming the so would allow us to delete some code such as @pre_process and APIRequest.with_data and have a more uniform code base.

@totycro totycro added the enhancement New feature or request label Nov 4, 2024
@tomkralidis tomkralidis added this to the 0.19.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants