chore: deprecate storage default state

Author: kp2pml30

executor/common/src/calldata/de.rs

@@ -725,6 +725,7 @@ impl<'de> serde::Deserializer<'de> for Value {
     {
         match self {
             Value::Array(v) => visit_array(v, visitor),
+            Value::Bytes(v) => visitor.visit_byte_buf(v),
             _ => Err(self.invalid_type(&visitor)),
         }
     }

executor/src/host/message.rs

@@ -61,6 +61,10 @@ impl SlotID {
         ret.0.copy_from_slice(digest.finalize().as_slice());
         ret
     }
+
+    pub fn from_bytes(data: [u8; 32]) -> Self {
+        SlotID(data)
+    }
 }
 
 impl From<[u8; 32]> for SlotID {

executor/src/lib.rs

@@ -96,7 +96,7 @@ pub async fn run_with_impl(
         wasi::genlayer_sdk::StorageHostHolder(
             supervisor.host.clone(),
             wasi::genlayer_sdk::ReadToken {
-                mode: public_abi::StorageType::Default,
+                mode: public_abi::StorageType::LatestNonFinal,
                 account: entry_data.message.contract_address,
             },
         ),

executor/src/rt/vm/storage.rs

@@ -12,9 +12,19 @@ impl PageID {
     pub fn to_bytes(&self) -> [u8; 36] {
         let mut res = [0u8; 36];
         res[..32].copy_from_slice(&self.0.raw());
-        res[32..].copy_from_slice(&self.1.to_le_bytes());
+        res[32..].copy_from_slice(&self.1.to_be_bytes());
         res
     }
+
+    pub fn from_bytes(data: [u8; 36]) -> Self {
+        let mut slot_bytes = [0u8; 32];
+        slot_bytes.copy_from_slice(&data[..32]);
+        let slot_id = SlotID::from_bytes(slot_bytes);
+        let mut index_bytes = [0u8; 4];
+        index_bytes.copy_from_slice(&data[32..]);
+        let index = u32::from_be_bytes(index_bytes);
+        Self(slot_id, index)
+    }
 }
 
 #[derive(Debug, Clone, serde::Serialize)]
@@ -369,3 +379,30 @@ impl<HS: HostStorageLocking + Send + Sync> Storage<HS> {
         Ok(res)
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn pages_sorted_correctly_1_byte() {
+        let left = PageID(SlotID::from_bytes([1u8; 32]), 5);
+        let right = PageID(SlotID::from_bytes([1u8; 32]), 10);
+        assert!(left < right);
+        assert!(left.to_bytes() < right.to_bytes());
+
+        assert!(right > left);
+        assert!(right.to_bytes() > left.to_bytes());
+    }
+
+    #[test]
+    fn pages_sorted_correctly_2_byte() {
+        let left = PageID(SlotID::from_bytes([1u8; 32]), 5);
+        let right = PageID(SlotID::from_bytes([1u8; 32]), 1024);
+        assert!(left < right);
+        assert!(left.to_bytes() < right.to_bytes());
+
+        assert!(right > left);
+        assert!(right.to_bytes() > left.to_bytes());
+    }
+}