Merge pull request #1025 from gempy-project/changes_while_prob

[ENH] Add group_by parameter to structural_elements_from_borehole_set and plotting improvements

Author: Leguark

docs/developers_notes/dev_log/2025_05.md

@@ -0,0 +1,9 @@
+### From gempy_prob notes:
+**Saving models**
+- ? Do we want to try to save the full input as versioning so that we can just have one system to go back and forth?
+- A way to save the model already with the correct **nugget effects** instead of having to "load nuggets"
+
+# TODO: 
+-[ ] Saving and loading models 
+-[ ] Better api for nugget effect optimization
+

gempy/API/initialization_API.py

@@ -1,5 +1,5 @@
 import warnings
-from typing import Union, Hashable
+from typing import Union, Hashable, Literal
 
 import numpy as np
 from numpy import ndarray
@@ -104,7 +104,9 @@ def create_geomodel(
 
 def structural_elements_from_borehole_set(
         borehole_set: "subsurface.core.geological_formats.BoreholeSet",
-        elements_dict: dict) -> list[StructuralElement]:
+        elements_dict: dict,
+        group_by: Literal['component lith', 'lith_ids'] = 'lith_ids'
+) -> list[StructuralElement]:
     """Creates a list of StructuralElements from a BoreholeSet.
 
     Args:
@@ -123,7 +125,7 @@ def structural_elements_from_borehole_set(
     borehole_set: ss.core.geological_formats.BoreholeSet
 
     elements = []
-    component_lith: dict[Hashable, np.ndarray] = borehole_set.get_bottom_coords_for_each_lith()
+    component_lith: dict[Hashable, np.ndarray] = borehole_set.get_bottom_coords_for_each_lith(group_by=group_by)
 
     for name, properties in elements_dict.items():
         top_coordinates = component_lith.get(properties['id'])

gempy/core/data/grid.py

@@ -118,11 +118,11 @@ def bounding_box(self):
         return bounding_box_points
 
     @property
-    def active_grids(self):
+    def active_grids(self) -> GridTypes:
         return self._active_grids
 
     @active_grids.setter
-    def active_grids(self, value):
+    def active_grids(self, value: GridTypes):
         self._active_grids = value
         self._update_values()