Fix TODO These may not get called after the end of the threading #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from threading.Timer to time.sleep. This causes the capture_image function to complete before running the follow-on GIF and Video creation. This fixes the TODO that allowed GIF and Video creation to run after the first image capture, but before the 2nd-nth image captures.
Also change from if-statement to a for-statement before and after capture.
Finally move camera start-up and shut-down outside of the for loop.
Lastly remove the sys.exit so the function does not cause the script to terminate without running the GIF and Video creation.