Skip to content

Fix some warnings on macOS with clang #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techee wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some warnings on macOS with clang #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
249602f
vimode: remove unused variable
techee Jul 4, 2025
ec6fdae
workbench: remove unused variable
techee Jul 4, 2025
393f922
lsp: fix warning on macOS
techee Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lsp/src/lsp-log.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void lsp_log(LspLogInfo log, LspLogType type, const gchar *method, GVariant *par
if (req_time)
{
GTimeSpan delta = g_date_time_difference(time, req_time);
delta_str = g_strdup_printf(" (%ld ms)", delta / 1000);
delta_str = g_strdup_printf(" (%ld ms)", (long)(delta / 1000));
}
else
delta_str = g_strdup("");
Expand Down
2 changes: 1 addition & 1 deletion lsp/src/lsp-progress.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ void lsp_progress_process_notification(LspServer *srv, GVariant *params)
);
if (have_percentage)
{
g_snprintf(buf, 30, "%ld%%", percentage);
g_snprintf(buf, 30, "%ld%%", (long)percentage);
message = buf;
}
}
Expand Down
2 changes: 0 additions & 2 deletions vimode/src/keypress.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ void kpl_printf(GSList *kpl)
gint kpl_get_int(GSList *kpl, GSList **new_kpl)
{
gint res = 0;
gint i = 0;
GSList *pos = kpl;
GSList *num_list = NULL;

Expand All @@ -186,7 +185,6 @@ gint kpl_get_int(GSList *kpl, GSList **new_kpl)
{
res = res * 10 + kp_todigit(pos->data);
pos = g_slist_next(pos);
i++;
// some sanity check
if (res > 1000000)
break;
Expand Down
6 changes: 1 addition & 5 deletions workbench/src/utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ gchar *get_combined_path(const gchar *base, const gchar *relative)
**/
gchar *get_any_relative_path (const gchar *base, const gchar *target)
{
guint index = 0, equal, equal_index = 0, base_parts = 0, target_parts = 0, length;
guint index = 0, equal, equal_index = 0, base_parts = 0, length;
GPtrArray *relative;
gchar *part;
gchar *result = NULL;
Expand All @@ -160,10 +160,6 @@ gchar *get_any_relative_path (const gchar *base, const gchar *target)
index = 0;;
while (splitv_target[index] != NULL)
{
if (strlen(splitv_target[index]) > 0)
{
target_parts++;
}
index++;
}

Expand Down