Cleanup: Remove duplicated auth and DB logic after PR #58

[shishir-21]

After merging PR #58, I noticed some duplicated or conflicting blocks in the codebase.

Examples:

• server.js: duplicated MongoDB connection logic, repeated auth route declarations, and repeated fs.readFile blocks.
• AuthControllers.js: duplicated constants and object definitions.

This does not block functionality, but cleaning it up would improve maintainability and reduce the risk of future bugs.

Happy to help with a follow-up PR if this is okay.

Related to: PR #58

[gbowne1]

@shishir-21

Yes, this needs a PR as it has broken #87 slightly

It's really hard to trap duplicate code without tests so Vitest tests should happen soon

Maybe small refinement to #87?

@glenjaysondmello

[glenjaysondmello]

Thanks for the clarification.

I’m happy to open a separate focused cleanup PR for #90 to remove duplicated DB/auth blocks if that’s helpful, so we keep #87 scoped to tooling and CI.

[gbowne1]

Did you comment @glenjaysondmello? I only got a email comment. Doesn't appear in GitHub.

Either way, yeah we need to get through all of the open PRs merge at least most of it then do some refactoring.

I realized now that having a single file house everything is not ideal and causes issues when having people collaborate and contribute especially all at once.

Yes we should definitely separate everything into individual files.

I am happy to invite those who wish to stick with this project till MVP to be collaborators

Sounds great to me. I don't know what caused issues with #87.

Any PRs should be attached to the issue regarding separate files etc this will be #77 and #78

[glenjaysondmello]

Thanks @gbowne1 — that's very helpful.

I'll start a small, focused refactor to split the monolithic server file into individual modules (db, routes, controllers) and open a separate PR linked to #90 (cleanup) and referencing #77 / #78 for the larger file-structure changes.

[gbowne1]

What do we do about #87 then? The CI broke when I merged a PR.

Its gotten fragile because of the structure.

I'd rather finish merging what open PRs there are then starting the refactoring at that point.

We can hold all new issues and PRs till the refactoring is completed into separate items a for both the monolithic main.js and server.js files into separate modules with a main app referencing #77 and #78 much like https://github.com/gbowne1/RadioLogger is

[glenjaysondmello]

Thanks @gbowne1 — that makes sense.

I'll pause any further large refactors until the open PRs are merged and we have the green light to split the monoliths into modules.

[gbowne1]

Yeah otherwise we would be just going in circles.

I invited you if you want to help out reviewing etc. It makes that easier.

I generally merge after 2 approved reviews (beyond mine) that get a ✅ in the review UI on github

[glenjaysondmello]

@gbowne1 Thank you for the invitation! I really appreciate it—I've just accepted.

[gbowne1]

I went and merged a few PRs including #87 as a WIP so things don't get even more stale

Make sure everyone gets synced to current master

We should also think about adding test and main branch too to be a bit closer to git flow operating

[gbowne1]

@glenjaysondmello @shishir-21

In server.js, We still have

await mongoose.connect(MONGODB_URI);   // First time
mongoose.connect(MONGODB_URI)          // Second time

We also have

app.use(cors({ origin: 'http://localhost:3000' }));

Then later we do...

app.use(cors({
  origin: process.env.CLIENT_URL || 'http://localhost:3000',
  credentials: true,
}));

app.post('/api/auth/register', AuthControllers.register);
app.post('/api/auth/login', AuthControllers.login);

Then later we do..

app.post('/api/auth/register', AuthControllers.register);
app.post('/api/auth/login', AuthControllers.login);

[glenjaysondmello]

since these duplicates are all in server.js, should one of us open a small dedicated cleanup PR for #90, or should whoever is already modifying server.js in an active PR include these fixes there?