Creating node sometimes segfaults in linux

[osrf-migration]

Original report (archived issue) by Poh Zhi-Ee (Bitbucket: Poh Zhi-Ee).

---

This is due to the lack of error handling for the getpwuid_r() call in the username() function in NetUtils.cc
According to the getpwuid_r manpage the function is not always successful. Failing to handle the errors but continuing to use the passwd struct can result in the use of a corrupted data structure which causes a segfault.

Additional information:
Stack trace of the segfault

‌

[osrf-migration]

Original comment by Poh Zhi-Ee (Bitbucket: Poh Zhi-Ee).

---

• Edited issue description

[osrf-migration]

Original comment by Poh Zhi-Ee (Bitbucket: Poh Zhi-Ee).

---

• Edited issue description

[osrf-migration]

Original comment by Poh Zhi-Ee (Bitbucket: Poh Zhi-Ee).

---

• Edited issue description

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

See pull request #441 and its backport in pull request #444.