Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI broken between 7.1.0 and 7.2.0 #115

Open
osrf-migration opened this issue Dec 18, 2019 · 4 comments
Open

ABI broken between 7.1.0 and 7.2.0 #115

osrf-migration opened this issue Dec 18, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


A parameter with a default value was added to ignition::transport::log::Playback::Start in pull request #401. It was merged and released in 7.2.0, but we didn't notice the complaints by the ABI checking job:

cc @j-rivero

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


the ABI breakage was merged forward to ign-transport8 in pull request #419, fixed in ign-transport8 in pull request #425, and merged forward to default in pull request #426

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


do we want to change anything on ign-transport7? the breakage has already been released in 7.2.0 and 7.2.1.

cc @j-rivero

@osrf-migration
Copy link
Author

Original comment by Jose Luis Rivero (Bitbucket: Jose Luis Rivero, GitHub: j-rivero).


Ideally we should revert it as soon as possible in a new version. For the unreleased branches please revert the change asap.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


targeting ABI fix to ign-transport7 in pull request #427

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
@chapulina chapulina removed the major label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants