-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service to change camera follow pgain. #515
Add service to change camera follow pgain. #515
Conversation
@osrf-jenkins run tests please! |
Head branch was pushed to by a user without write access
e596e32
to
290c060
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-gui7 #515 +/- ##
===========================================
- Coverage 72.98% 69.18% -3.80%
===========================================
Files 55 44 -11
Lines 4927 4930 +3
===========================================
- Hits 3596 3411 -185
- Misses 1331 1519 +188 ☔ View full report in Codecov by Sentry. |
6150395
to
ed5167d
Compare
c386760
to
66fbe33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new service calls and Follow Config
plugin work well for me
66fbe33
to
c265538
Compare
c265538
to
55e73fe
Compare
|
||
msgs::StringMsg reqName; | ||
reqName.set_data(this->followTargetName); | ||
node.Request(this->followTargetNameService, reqName, cbName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using async service requests, you'll need to synchronize access to all the variables used by the callback since the callbacks will happen from a different thread than the Qt thread. This could help with the CI failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, just copy-capture the variable in the lambda. I think this is a lot easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will finally get back to looking at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bperseghetti did you address the feedback ?
@bperseghetti I haven't seen any movement on this one and it targets garden branches, so I'm going to remove the beta label for now. |
@bperseghetti , friendly ping. Could you review the feedback and we'll try to merge this patch? |
Yeah, will look it over again here this weekend and see if I can't make the requested changes. |
Example: gz service -s /gui/follow/pgain --reqtype gz.msgs.Double --reptype gz.msgs.Boolean --timeout 2000 --req 'data: 1.0' Signed-off-by: Benjamin Perseghetti <[email protected]>
Allows for follow camera control set from sdf as well as gui. Signed-off-by: Benjamin Perseghetti <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Ian Chen <[email protected]> Signed-off-by: Benjamin Perseghetti <[email protected]>
935c53c
to
568545f
Compare
White space cleanup. Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
@bperseghetti there are CI errors: /home/jenkins/workspace/gz_gui-ci-pr_any-focal-amd64/gz-gui/test/integration/follow_config.cc:162
Expected: (sleep) < (maxSleep), actual: 61 vs 60 |
I actually was planning to close this and open a new PR that has a more "holistic" approach to controlling the follow camera including what was done in here but more. I just need to rebase that work on humble as I no longer plan to target it to garden (due to relatively sooner EOL). |
Closing in favor of PR #619 |
🦟 Bug fix
Fixes #514
Summary
Now you can set the pgain of the follow camera when following objects. This is needed for extremely high speed objects.
better.mp4
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.