Merge pull request #100 from gavinr/milestone-fix

Milestone fix

Author: gavinr

.github/workflows/release.yml

@@ -9,13 +9,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Setup Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
-          node-version: 'lts/*'
+          node-version: "lts/*"
       - name: Install dependencies
         run: npm ci
       - name: Release

.github/workflows/test.yml

@@ -7,8 +7,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: "lts/*"
       - run: npm ci
       - run: npm run build --if-present
       - run: npm test

README.md

@@ -32,7 +32,7 @@ Instructions for exporting or importing:
 
 ### To Import Issues
 
-Currently imports title, body, labels, status (closed or open) and milestones.
+Currently imports title, body, labels, status (closed or open) and milestones. See the [test](/test) folder for example input formats.
 
 ```bash
 githubCsvTools myFile.csv

helpers.js

@@ -1,20 +1,25 @@
 const createIssue = (octokit, issueInfo, organization, repository) => {
   return new Promise((resolve, reject) => {
-    octokit.request("POST /repos/" + organization + "/" + repository + "/import/issues", issueInfo).then(
-      (res) => {
-        // console.log("res", res);
-        if (res.status === 202) {
+    octokit
+      .request(
+        "POST /repos/" + organization + "/" + repository + "/import/issues",
+        issueInfo
+      )
+      .then(
+        (res) => {
+          // console.log("res", res);
+          if (res.status === 202) {
             console.log(`Imported issue: ${issueInfo.issue.title}`);
             resolve(res);
-        } else {
-          // error creating the issue
-          reject(res);
+          } else {
+            // error creating the issue
+            reject(res);
+          }
+        },
+        (err) => {
+          reject(err);
         }
-      },
-      (err) => {
-        reject(err);
-      }
-    );
+      );
   });
 };
 

import.js

@@ -16,7 +16,7 @@ const importFile = (octokit, file, values) => {
       },
       (err, csvRows) => {
         if (err) throw err;
-        const cols = csvRows[0].map(col => col.toLowerCase());
+        const cols = csvRows[0].map((col) => col.toLowerCase());
         csvRows.shift();
 
         // get indexes of the fields we need
@@ -33,7 +33,7 @@ const importFile = (octokit, file, values) => {
         }
         const createPromises = csvRows.map((row) => {
           const sendObj = {
-            issue : {}
+            issue: {},
           };
 
           sendObj.issue.title = row[titleIndex];
@@ -50,7 +50,7 @@ const importFile = (octokit, file, values) => {
 
           // if we have a milestone column, pass that.
           if (milestoneIndex > -1 && row[milestoneIndex] !== "") {
-            sendObj.issue.milestone = row[milestoneIndex];
+            sendObj.issue.milestone = Number(row[milestoneIndex]);
           }
 
           // if we have an assignee column, pass that.
@@ -61,16 +61,25 @@ const importFile = (octokit, file, values) => {
           if (stateIndex > -1 && row[stateIndex].toLowerCase() === "closed") {
             sendObj.issue.closed = true;
           }
-          return createIssue(octokit, sendObj, values.userOrOrganization, values.repo);
+          return createIssue(
+            octokit,
+            sendObj,
+            values.userOrOrganization,
+            values.repo
+          );
         });
 
         Promise.all(createPromises).then(
           (res) => {
             const successes = res.filter((cr) => {
-              return cr.status === 200 || cr.status === 201 || cr.status === 202;
+              return (
+                cr.status === 200 || cr.status === 201 || cr.status === 202
+              );
             });
             const fails = res.filter((cr) => {
-              return cr.status !== 200 && cr.status !== 201 && cr.status !== 202;
+              return (
+                cr.status !== 200 && cr.status !== 201 && cr.status !== 202
+              );
             });
 
             console.log(
@@ -81,7 +90,7 @@ const importFile = (octokit, file, values) => {
             );
 
             if (fails.length > 0) {
-              console.error('ERROR - some of the imports have failed');
+              console.error("ERROR - some of the imports have failed");
               console.log(fails);
             }
 

index.js

@@ -10,7 +10,7 @@ const { importFile } = require("./import.js");
 const { exportIssues } = require("./export.js");
 
 program
-  .version(require('./package.json').version)
+  .version(require("./package.json").version)
   .arguments("[file]")
   .option(
     "-g, --github_enterprise [https://api.github.my-company.com]",