Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS config for third-party applications #210

Open
sklirg opened this issue Apr 7, 2019 · 0 comments
Open

CORS config for third-party applications #210

sklirg opened this issue Apr 7, 2019 · 0 comments

Comments

@sklirg
Copy link
Contributor

sklirg commented Apr 7, 2019

Over at https://github.com/sklirg/pocket-gondul I require some CORS changes to be able to work with the Gondul API.

I'm not sure what the best way to resolve this issue is, but here are some suggestions:

  1. CORS whitelist origins
  • Manual, tedious, has to be updated for new third-party applications...
  1. CORS whitelist all origins
  • ⚠️ Bypasses the point of CORS...
  1. Host the third-party applications on the same domain as Gondul
  • Drastically reduces the simplicity of developing against the API

Further thoughts:

Consider whitelisting some other HTTP methods, as well as the Authorization header. GET/HEAD is currently allowed through, but not with Authorization, so only for same-origin requests, where CORS isn't an issue... :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant