-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem installing lap if numpy not already installed #38
Comments
Hi @shachargluska, thanks for reporting this, I am aware of this being suboptimal and have it on the todo list to be patched. My plan is to get rid of the current setup.py altogether, ideally going for poetry. Lately I don't have much spare time on my hands, so this might take a while. If you had time, experience and will to help with that, let me know. Cheers, |
Why not just passing |
Same issue here. Environment;
Here is my
Error details:
|
same error |
Yes, I successfully installed the LAP library when using version 22.0.3 of PIP. So, for now, you can use this version of pip for installation. |
I am also having this issue. |
same error |
I think the error probably depends on the pip version. (python 3.9.10) I had a error in pip but pip |
Thank you. I've been searching online for a long time but I can't find a solution. Your method is actually useful |
Inspired by mp075496706 and izagood, I solved the problem with the following lines of command.
|
I'm running into the same error when installing with https://github.com/mitsuhiko/rye instead of pip There seems to be no work around with rye add numpy
rye sync
rye run python -c 'import numpy; print(numpy.__version__)' # prints 1.26.1 for me
rye add lap
rye sync # fails with ImportError: lap requires numpy, please "pip install numpy". |
Same error with poetry 1.6.1 |
Hi,
looks like setup.py raises an ImportError if lap can't find numpy.
pip install lap[alldeps]
still throws this error, but succeeds with pip 20.0.2.For pip 22.0.3, this fails again:
pip install numpy lap
also doesn't solve this, because lap is (possible) setup before numpy.I think checking for the import in setup.py is problematic, since setuptools.setup isn't called yet.
I think the import check should be moved to the package itself.
Currently this can be worked around by using 2 separate pip calls. This makes it harder to include lap in a requirements.txt file.
The text was updated successfully, but these errors were encountered: