[FEATURE] Allow ddev sitename in domain

[mschwemer]

Thanks for this browser-sync example. :-) It works really well. I like it!

I added that as an additional ddev service

services:
  t3docs:
    container_name: "ddev-${DDEV_SITENAME}-t3docs"
    image: ghcr.io/garvinhicking/typo3-documentation-browsersync:latest
    labels:
      com.ddev.site-name: ${DDEV_SITENAME}
      com.ddev.approot: ${DDEV_APPROOT}
    restart: "no"
    ports:
    - "16108:5173"
    environment:
      - VIRTUAL_HOST=${DDEV_HOSTNAME}
    volumes:
        - "${DDEV_APPROOT}/Documentation:/project/Documentation"
        - "${DDEV_APPROOT}/Documentation-GENERATED-temp:/project/Documentation-GENERATED-temp"
        - ".:/mnt/ddev_config"

Calling the docs via http://localhost:16108/ works fine. If I call it with DDEV_SITENAME, I get the following error:

Blocked request. This host ("powermail-pro.ddev.site") is not allowed.
To allow this host, add "powermail-pro.ddev.site" to `server.allowedHosts` in vite.config.js.

Would it be possible to allow the DDEV_HOSTNAME there too. Then it would be more clear, in which context somebody is using it

(... and hopefully, the port does not have to be changed for every project. I will figure it out with Randy at the T3CRR).

[garvinhicking]

Happy to hear! I'll also be at T3CRR, maybe we can discuss this.

I think it should be possible to route the env var through to vite, yes. I will investigate this next week.

Bear in mind that the TYPO3 render-guides docker container is also taking steps to make my project obsolete through internal hot-reloading and love-serving. We should take DDEV ENV routing there into consideration directly. I try to keep this in mind.

[garvinhicking]

@mschwemer please check out TYPO3-Documentation/render-guides#1055 - this was merged today, a release should follow soon.

We'll look into making the port configurable.

If you could try out the PR / current main there also, that would be lovely :-)

[mschwemer]

@garvinhicking Thanks for the fast action. I build the docker image and was able to run the live reloading.

Live reloading works with http://localhost: <CustomPort>.
Display of the documentation works with http://my-project.ddev.site: <CustomPort>, but not the live reload.

The exception in the JS console is

Websocket connection to ws://<my-project>.ddev.site:16108/ws failed 
anonymous @ (index) :364

My docker-compose for ddev:

services:
  t3docs:
    container_name: "ddev-${DDEV_SITENAME}-t3docs"
    image: typo3-docs:local
    labels:
      com.ddev.site-name: ${DDEV_SITENAME}
      com.ddev.approot: ${DDEV_APPROOT}
    restart: "no"
    command: --config=Documentation --watch
    ports:
      - "16108:1337"
    volumes:
        - "${DDEV_APPROOT}/.:/project"
        - ".:/mnt/ddev_config"

Besides that little glitch: Awesome 👍 Thank you!

[garvinhicking]

@mschwemer Could you maybe post this as an issue to the TYPO3 render-guides repo and tag @jaapio there? I told him about this effort yesterday and I guess there should be a possibility.

I think I will not maintain this project here any more because of that, so any effort is probably moot now.

[mschwemer]

I moved my comment as suggested.

Thx