Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreImagesRepresentativeNC plan #5173

Open
ChrisJefferson opened this issue Oct 27, 2022 · 0 comments
Open

PreImagesRepresentativeNC plan #5173

ChrisJefferson opened this issue Oct 27, 2022 · 0 comments

Comments

@ChrisJefferson
Copy link
Contributor

This is a PR to discuss a plan for converting PreImagesRepresentative to PreImagesRepresentativeNC, which would follow on from #5073 (there are a few methods being considered, but I'll just refer to PreImagesRepresentative here).

I don't have a plan, mainly just a list of comments :)

At present packages install PreImagesRepresentative, but in many cases the function they are installing needs renaming to PreImagesRepresentativeNC. While doing this, those packages may want to write a "proper" PreImagesRepresentative.

The question is, how to handle the "partially converted" world, where some packages have added PreImagesRepresentativeNC and a "proper" PreImagesRepresentative, and other packages have an old PreImagesRepresentative which is equivalent to PreImagesRepresentativeNC and no PreImagesRepresentativeNC?

I would be happy to put some thought into this question, but I don't have an immediate and good answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant