Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images in manuals #55

Closed
olexandr-konovalov opened this issue Oct 4, 2018 · 2 comments · Fixed by #93
Closed

Support images in manuals #55

olexandr-konovalov opened this issue Oct 4, 2018 · 2 comments · Fixed by #93

Comments

@olexandr-konovalov
Copy link
Member

The problem: the doc directory of the package has .png files, displayed in the manual, but ReleaseTools does not copy them into the gh-pages branch of the package. Is there a way to specify that they should be copied as well?

@fingolfin
Copy link
Member

You'd have to add .png in this line

for ext in css html js txt ; do

Feel free to submit a PR doing that.

The proper long-term fix is to add some way for packages to perform arbitrary actions when "installing" their manual(s).

@olexandr-konovalov
Copy link
Member Author

Does not seem possible at the moment since only files with these extensions are copied:

for ext in css html js txt ; do

What would be a proper way to allow this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants