Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portability problems #35

Closed
markuspf opened this issue Feb 26, 2016 · 4 comments
Closed

Portability problems #35

markuspf opened this issue Feb 26, 2016 · 4 comments

Comments

@markuspf
Copy link
Member

The release script seems to have a couple of portability problems. Here are the ones I have identified so far (using DragonFly BSD).

  • I can only reliably get the script to run using bash, neither zsh nor /bin/sh work. One of the issues is obviously the read -d feature that is used, but that's supported by zsh. It seems that zsh does not like for i in $ARCHIVE_FORMATS.
  • The script seems to be assuming gnu-ish sed/awk, because the parsing of json fails in jsonval, replacing sed/awk with gsed/gawk "solves" the problem for me.
@fingolfin
Copy link
Member

This should be fixed now. I tried with bash, dash and zsh -- note that zsh is compatible when run in "sh emulation mode", e.g. if it is installed as system shell /bin/sh. If you run the release script directly via zsh release, that won't quite work.

@fingolfin
Copy link
Member

And yeah, all of this would be avoided if the whole thing was written completly in python... I am tempted to do that, but of course such a rewrite will loose all the testing efforst I already put into this, and would take some time to stabilize again. I am certainly interested, but for now, it was more efficient for me to just adapt the existing shell script.

@fingolfin
Copy link
Member

@markuspf Can you confirm whether it works now for you?

@fingolfin
Copy link
Member

Since I heard nothing again, I'll assume this is resolved. If not, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants