Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package test errors: Ignore mypy errors caused by social-auth-core 4.5.5 #19620

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 14, 2025

Fixes #19617

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer dependencies Pull requests that update a dependency file labels Feb 14, 2025
@jdavcs jdavcs added this to the 25.0 milestone Feb 14, 2025
@jdavcs jdavcs requested a review from nsoranzo February 14, 2025 16:40
@jdavcs
Copy link
Member Author

jdavcs commented Feb 14, 2025

The new mypy failures seem to be exposing legitimate bugs in our code.

@nsoranzo
Copy link
Member

The new mypy failures seem to be exposing legitimate bugs in our code.

Those are fixed in #19614 .

Because it is used in package tests
@jdavcs jdavcs force-pushed the dev_socialauthcore_types branch from ca1ade3 to d85363c Compare February 14, 2025 22:06
@jdavcs
Copy link
Member Author

jdavcs commented Feb 18, 2025

@nsoranzo I think this is ready?

@jdavcs jdavcs merged commit 2acce63 into galaxyproject:dev Feb 19, 2025
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer dependencies Pull requests that update a dependency file kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancies in column types for social-auth-core derived database tables
2 participants