Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve fork with lil-http-terminator #36

Open
objectiveSee opened this issue Dec 13, 2021 · 0 comments
Open

Resolve fork with lil-http-terminator #36

objectiveSee opened this issue Dec 13, 2021 · 0 comments

Comments

@objectiveSee
Copy link

Hello. I think this is a great library, but the points made by the author of lil-http-terminator are very valid. That author has removed a lot of unnecessary dependencies and made a smaller project. I agree with their best practices of introducing the minimal amount of code dependencies for both package size as well as code stability reasons.I think it would be nice if these two projects could merge back together and that we could create a plan for getting them back in sync. It would be annoying to find a bug in one and have to fix it in both. Are you open to resolving this fork? Would be happy to help in any ways!

https://www.npmjs.com/package/lil-http-terminator

This module was forked from the amazing http-terminator. The important changes:

Zero dependencies, 11 KB on your disk. The original http-terminator brings in more than 20 sub-dependencies, >450 files, 2 MB total.
Removed TypeScript and a dozen of supporting files, configurations, etc. No more code transpilation.
Simpler API. Now you do require("lil-http-terminator")({ server }); to get a terminator object.
The termination never throws. You don't want to handle unexpected exceptions during your server shutdown.
Termination won't hang forever if server never closes the port because some browsers disrespect connection:close header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant