From a3eba439d972c3c287106150407bb2b9892b8d0f Mon Sep 17 00:00:00 2001
From: GerdP <GerdP@0c6e7542-c601-0410-84e7-c038aed88b3b>
Date: Sun, 21 Jan 2024 07:34:04 +0000
Subject: [PATCH] fix #23423 Memory leak: Markerlayer doesn't remove
 MouseListener - add removeMouseListener() call in destroy()

git-svn-id: https://josm.openstreetmap.de/svn/trunk@18948 0c6e7542-c601-0410-84e7-c038aed88b3b
---
 .../josm/gui/layer/markerlayer/MarkerLayer.java       | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java b/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java
index 768e0c21e75..8d832fe0a8a 100644
--- a/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java
+++ b/src/org/openstreetmap/josm/gui/layer/markerlayer/MarkerLayer.java
@@ -100,6 +100,8 @@ public class MarkerLayer extends Layer implements JumpToMarkerLayer, IGeoImageLa
     final BasicStroke markerStroke = new StrokeProperty("draw.rawgps.markers.stroke", "1").get();
 
     private final ListenerList<IGeoImageLayer.ImageChangeListener> imageChangeListenerListenerList = ListenerList.create();
+    private MarkerMouseAdapter mouseAdapter;
+    private MapView mapView;
 
     /**
      * The default color that is used for drawing markers.
@@ -192,12 +194,19 @@ public synchronized void destroy() {
         fromLayer = null;
         data.forEach(Marker::destroy);
         data.clear();
+        if (mouseAdapter != null && mapView != null)
+            mapView.removeMouseListener(mouseAdapter);
         super.destroy();
     }
 
     @Override
     public LayerPainter attachToMapView(MapViewEvent event) {
-        event.getMapView().addMouseListener(new MarkerMouseAdapter());
+        if (mapView != null) {
+            Logging.warn("MarkerLayer was already attached to a MapView");
+        }
+        mapView = event.getMapView();
+        mouseAdapter = new MarkerMouseAdapter();
+        mapView.addMouseListener(mouseAdapter);
 
         if (event.getMapView().playHeadMarker == null) {
             event.getMapView().playHeadMarker = PlayHeadMarker.create();