Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Example Commands in README.md, in 'Build and Install' section, Label: Documentation #1300

Open
ktprezes opened this issue Jun 4, 2024 · 0 comments

Comments

@ktprezes
Copy link

ktprezes commented Jun 4, 2024

Problem Description:
In the readme.md#Build and Install section of the README, the 1st provided example does not work on Windows 11 with MSVS 2022. Specifically, the following lines have issues:

cmake --build build -- all
cmake --build build -- install

Possible Solution:
After testing, I found that the correct commands should be:

cmake --build build --target ALL_BUILD
cmake --build build --target INSTALL

At least these commands work correctly on my system.

Justification:
The current version of the commands might be confusing, especially for CMake beginners.
Updating the commands in the README would likely help new users avoid confusion and build issues.

Thank you for your attention to this matter and for maintaining such a useful project!

Best regards,
Tadeusz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant