Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handling invalid input for duration field #133

Open
jareware opened this issue Mar 28, 2020 · 1 comment
Open

Gracefully handling invalid input for duration field #133

jareware opened this issue Mar 28, 2020 · 1 comment
Labels
bug Something isn't working front-end front-end related issues

Comments

@jareware
Copy link
Contributor

jareware commented Mar 28, 2020

It seems that quite a few people have added some extra characters to the "number of days of symptoms" field. Like "7p" or "7 " instead of just "7". Our draconian validation rules have rejected such input, and our privacy-oriented design means there's no logs of those rejected payloads. 🤦‍♂️

For instance, during the 27th (big public launch) we got a total of 26779 responses, and total of 264 such failures. Many of these also seem to be the same person trying a few times to submit, only to get the "couldn't submit, please try again" error. A cursory glance over the logs suggests something like 10 retries on average, before the participant either gets it right, or gives up. So with those numbers, for the 27th, we've lost ~0.1% of potential responses due to this overly-strict validation. 😿

Some folks apparently also put in e.g. "-", or "?" or some such. These should be automatically converted to empty, while "7 " should obviously be treated the same as "7".

@jareware jareware added the bug Something isn't working label Mar 28, 2020
@jareware
Copy link
Contributor Author

image

jareware added a commit that referenced this issue Mar 30, 2020
@sjarva sjarva added the front-end front-end related issues label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end front-end related issues
Projects
None yet
Development

No branches or pull requests

2 participants