Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musicians: Manage Posts #10

Closed
6 tasks done
simonv3 opened this issue Apr 17, 2023 · 2 comments
Closed
6 tasks done

Musicians: Manage Posts #10

simonv3 opened this issue Apr 17, 2023 · 2 comments
Labels
enhancement New feature or request epic
Milestone

Comments

@simonv3
Copy link
Member

simonv3 commented Apr 17, 2023

  • Create
  • Read
  • Update
  • Soft Delete (part of Full soft deletion  #19)
  • Embed track in post
  • Mark posts as private or as public
@simonv3 simonv3 added enhancement New feature or request epic labels Apr 17, 2023
@simonv3 simonv3 changed the title Musicians: Posts Musicians: Manage Posts Apr 17, 2023
@simonv3 simonv3 added this to the MVP milestone Apr 18, 2023
@simonv3
Copy link
Member Author

simonv3 commented Apr 19, 2023

Look at this https://dev.to/patarapolw/securely-embed-youtube-and-other-iframe-elements-in-markdown-2hoc and https://github.com/remarkjs/react-markdown#security for security stuff on allowing iframes in markdown.

Turns out there might be a remark plugin for this: https://www.npmjs.com/package/@remark-embedder/core

@simonv3
Copy link
Member Author

simonv3 commented Apr 20, 2023

I had to tweak remark-embedder because of this problem remark-embedder/core#123 (comment) but once that's done it is possible to embed widgets 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic
Projects
None yet
Development

No branches or pull requests

1 participant