Merge pull request #195 from giusdp/main

Return err when deleting default module

Author: giusdp

apps/core/lib/core_web/controllers/module_controller.ex

@@ -18,6 +18,8 @@ defmodule CoreWeb.ModuleController do
   alias Core.Domain.Modules
   alias Core.Schemas.Module
 
+  @default_module "_"
+
   action_fallback(CoreWeb.FallbackController)
 
   def index(conn, _params) do
@@ -46,9 +48,15 @@ defmodule CoreWeb.ModuleController do
   end
 
   def delete(conn, %{"module_name" => name}) do
-    with {:ok, module} <- Modules.get_module_by_name(name),
-         {:ok, %Module{}} <- Modules.delete_module(module) do
-      send_resp(conn, :no_content, "")
+    if name == @default_module do
+      conn
+      |> put_status(:bad_request)
+      |> json(%{error: "Cannot delete default module"})
+    else
+      with {:ok, module} <- Modules.get_module_by_name(name),
+           {:ok, %Module{}} <- Modules.delete_module(module) do
+        send_resp(conn, :no_content, "")
+      end
     end
   end
 end

apps/core/test/core_web/integration/controllers/module_controller_test.exs

@@ -29,6 +29,8 @@ defmodule CoreWeb.ModuleControllerTest do
   }
   @invalid_attrs %{name: nil}
 
+  @default_module "_"
+
   setup %{conn: conn} do
     :ok = Sandbox.checkout(Core.SubjectsRepo)
     user = Subjects.get_subject_by_name("guest")
@@ -113,6 +115,11 @@ defmodule CoreWeb.ModuleControllerTest do
       conn = get(conn, Routes.function_path(conn, :show, module.name, function.name))
       assert response(conn, 404)
     end
+
+    test "error when deleting default module", %{conn: conn} do
+      conn = delete(conn, Routes.module_path(conn, :delete, @default_module))
+      assert response(conn, 400)
+    end
   end
 
   defp create_module(_) do