added delete op

Author: hellt

main.py

@@ -8,8 +8,12 @@
 def main():
     eda = EDAClient(base_url="https://devbox.panda-cobra.ts.net")
 
-    my_banner = banner("Let's have some model driven automation going on!")
-    eda.add_to_transaction_replace(my_banner)
+    my_banner = banner(
+        ns="clab-vlan",
+        name="my-banner",
+        motd_text="Let's have some model driven automation going on!",
+    )
+    eda.add_to_transaction_delete(my_banner)
     _ = eda.commit_transaction()
 
 

src/banner.py

@@ -1,17 +1,20 @@
 from models.com.nokia.eda.siteinfo.v1alpha1 import Banner, Metadata, Spec
 
+API_VERSION = "siteinfo.eda.nokia.com/v1alpha1"
+KIND = "Banner"
 
-def banner(motd_text: str) -> Banner:
+
+def banner(ns: str, name: str, motd_text: str) -> Banner:
     """
     Create a banner
     """
 
     banner = Banner(
-        apiVersion="siteinfo.eda.nokia.com/v1alpha1",
-        kind="Banner",
+        apiVersion=API_VERSION,
+        kind=KIND,
         metadata=Metadata(
-            name="banner",
-            namespace="clab-vlan",
+            name=name,
+            namespace=ns,
             labels={"app": "banner"},
         ),
         spec=Spec(motd=motd_text, nodeSelector=["containerlab=managed"]),

src/client.py

@@ -5,6 +5,8 @@
 from pydantic import BaseModel
 
 from models.core import (
+    GroupVersionKind,
+    NsCrGvkName,
     Transaction,
     TransactionContent,
     TransactionCr,
@@ -68,6 +70,11 @@ def add_to_transaction_replace(self, resource: BaseModel) -> None:
 
         self.add_to_transaction(resource, _REPLACE)
 
+    def add_to_transaction_delete(self, resource: BaseModel) -> None:
+        """Add resource to the delete list of a transaction"""
+
+        self.add_to_transaction(resource, _DELETE)
+
     def add_to_transaction(self, resource: BaseModel, type: TxType) -> None:
         """Add resource to transaction"""
 
@@ -78,15 +85,34 @@ def add_to_transaction(self, resource: BaseModel, type: TxType) -> None:
             )
         )
 
+        if (
+            content.apiVersion is None
+            or content.kind is None
+            or content.metadata is None
+        ):
+            raise ValueError(
+                f"Resource {content.apiVersion} {content.kind} is not a valid resource"
+            )
+
         logger.info(
             f"Adding '{content.kind}' resource from '{content.apiVersion}' to the '{type}' transaction list"
         )
 
         tx_type_mapping = {
             "create": TransactionType(create=TransactionValue(value=content)),
-            # "delete": TransactionType(delete=content),
+            "delete": TransactionType(
+                delete=NsCrGvkName(
+                    gvk=GroupVersionKind(
+                        group=content.apiVersion.split("/")[0],
+                        version=content.apiVersion.split("/")[1],
+                        kind=content.kind,
+                    ),
+                    name=content.metadata.name,
+                    namespace=content.metadata.namespace,
+                )
+            ),
             "modify": TransactionType(modify=TransactionValue(value=content)),
-            "replace": TransactionType(modify=TransactionValue(value=content)),
+            "replace": TransactionType(replace=TransactionValue(value=content)),
         }
 
         tx_cr = TransactionCr(type=tx_type_mapping[type])
@@ -114,6 +140,8 @@ def commit_transaction(self) -> Any:
             exclude_unset=True, exclude_none=True, exclude_defaults=True
         )
 
+        logger.info(f"Committing transaction: {content}")
+
         response = self.post(
             url=self.transaction_endpoint,
             content=content,