Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part 7e - "React/node-application security" references create-react-app #3392

Open
bambery opened this issue Jan 15, 2024 · 0 comments
Open

Comments

@bambery
Copy link
Contributor

bambery commented Jan 15, 2024

From: https://fullstackopen.com/en/part7/class_components_miscellaneous#react-node-application-security

Running npm audit fix --force would upgrade the library version but would also upgrade the library react-scripts and that would potentially break down the development environment. So we will leave the library upgrades for later...

Except this justification no longer makes sense, as react-scripts is a create-react-app library, and no longer used. There are 4 total references in this section to react-scripts that should be removed. I would submit a PR, but I don't know what the desired content/context is in the new vite world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant