Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetch() global function for http-requests over axios-library #3203

Open
kahlstrm opened this issue Oct 21, 2023 · 1 comment
Open

Use fetch() global function for http-requests over axios-library #3203

kahlstrm opened this issue Oct 21, 2023 · 1 comment

Comments

@kahlstrm
Copy link
Contributor

kahlstrm commented Oct 21, 2023

Given that fetch is available on all modern browsers and has been for quite many years, I wonder if there are any blockers in adapting the material to use that over the axios-library?
Is there a pedagogical reasons for using axios over the standard fetch, or is this just a remnant of the past when fetch wasn't widely available?

I'd argue that fetch is currently the de facto method for making HTTP-requests on the browser (and node), and would be a more practical API to learn over axios.

If this is something that is deemed a good idea, at some point in time I could contribute with PRs changing the Finnish and English materials and starter templates to use fetch. But anyone else is also free to contribute and pick this up.

@kahlstrm kahlstrm changed the title Use fetch() for http-requests over axios Use fetch() global function for http-requests over axios Oct 21, 2023
@kahlstrm kahlstrm changed the title Use fetch() global function for http-requests over axios Use fetch() global function for http-requests over axios-library Oct 21, 2023
@mluukkai
Copy link
Contributor

This is a good point. I'll consider this change for the 2024 edition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants