Skip to content

Commit a7342bb

Browse files
Update README.md
1 parent 9f6f0ea commit a7342bb

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

README.md

+5-12
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,13 @@ You can install the latest version via [NuGet](https://www.nuget.org/packages/Gr
1010
```
1111
PM> Install-Package GraphQL.Upload.AspNetCore
1212
```
13-
Preview versions from the develop branch are available via [GitHub Packages](https://github.com/JannikLassahn/graphql-dotnet-upload/packages). Use these if you are using **ASP.NET Core 3**.
13+
Preview versions from the develop branch are available via [GitHub Packages](https://github.com/JannikLassahn/graphql-dotnet-upload/packages).
1414

1515
## Usage
1616

17-
Register the middleware in your Startup.cs (in this case we're also using [graphql-dotnet/server](https://github.com/graphql-dotnet/server)).
17+
Register the middleware in your Startup.cs.
18+
19+
This middleware implementation **only** parses multipart requests. That's why we're using additional middleware ([graphql-dotnet/server](https://github.com/graphql-dotnet/server)) to handle other request types.
1820
```csharp
1921
public void ConfigureServices(IServiceCollection services)
2022
{
@@ -31,7 +33,7 @@ public void Configure(IApplicationBuilder app)
3133
```
3234

3335
Register a `FormFileConverter` within your MySchema.cs.
34-
```c#
36+
```csharp
3537
public class MySchema : Schema
3638
{
3739
public MySchema()
@@ -73,12 +75,3 @@ curl localhost:54234/graphql \
7375
-F map='{ "0": ["variables.file"] }' \
7476
7577
```
76-
77-
This middleware implementation **only** parses multipart requests. The sample app uses additional middleware that handles other cases (e.g. `POST` with `application/json`).
78-
79-
80-
## Roadmap
81-
- [ ] Make sure the implementation behaves according to the spec
82-
- [x] Add convenience extension methods for `ServiceCollection` and `ApplicationBuilder` that register the neccessary types
83-
- [ ] Feature parity with the [reference implementation](https://github.com/graphql-dotnet/server)
84-
- [ ] End to end sample with web based client

0 commit comments

Comments
 (0)