Skip to content

[WIP] trying to tame the slow tests #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enricosada wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] trying to tame the slow tests #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc498f
set test timeouts
enricosada Apr 19, 2019
b8314f3
the NUnit.Framework.Timeout is not avaiable in .net core
enricosada Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integrationtests/Paket.IntegrationTests.preview3/Paket.IntegrationTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DefineConstants>
PAKET_NETCORE;
NO_UNIT_PLATFORMATTRIBUTE;
NO_UNIT_TIMEOUTATTRIBUTE;
TESTSUITE_KNOWN_FAILURE_DOTNETCORE_3005;
FAKE_NETSTANDARD_API;
@(DefineConstants)
Expand Down
7 changes: 7 additions & 0 deletions integrationtests/Paket.IntegrationTests/TestHelper.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ open System
open System.IO
open Paket.Logging

#if NO_UNIT_TIMEOUTATTRIBUTE
#else
// global timeout for single tests, in ms
[<assembly: NUnit.Framework.Timeout(20_000)>]
do ()
#endif

let scenarios = System.Collections.Generic.List<_>()
let isLiveUnitTesting = AppDomain.CurrentDomain.GetAssemblies() |> Seq.exists (fun a -> a.GetName().Name = "Microsoft.CodeAnalysis.LiveUnitTesting.Runtime")

Expand Down
7 changes: 7 additions & 0 deletions tests/Paket.Tests/TestHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ open System.Xml
open System.IO
open Paket.Domain

#if NO_UNIT_TIMEOUTATTRIBUTE
#else
// global timeout for single tests, in ms
[<assembly: NUnit.Framework.Timeout(2_000)>]
do ()
#endif

let makeOrList (l:_ list) =
if l.IsEmpty then FrameworkRestriction.NoRestriction
else Seq.fold FrameworkRestriction.combineRestrictionsWithOr FrameworkRestriction.EmptySet l
Expand Down