Not found comments show default 404 page

[tom-sherman]

To Reproduce

Go to a comment route that doesn't exist (on a post that does exist), for example https://frontpage.fyi/post/tom.sherman.is/3ma6gwvnbyp2q/tom.sherman.is/notfound

It renders the fallback default 404.

Expected behavior

It should render the post view with a message to say comment not found

[tom-sherman]

While we're at it, let's give posts a 404 page. Comment 404s are more likely because a deleted comment without children will return 404 on its' permalink, while we still show the thread of deleted posts but it's still nice to have.

[timothyis]

Just to define this more:

If the comment has replies, should we render a faux comment with styling and messaging to say that the comment was deleted, but still show the replies?

Should that be the default behaviour anyway, even if it doesn't have replies? Or if reply-less, should we just render all the comments on the post and add an alert at the top to say that the linked comment doesn't exist

[tom-sherman]

@timothyis this doesn't apply to a comment with replies, that already has a UI. It shows as a deleted comment with the replies, it doesnt return a 404.

should we just render all the comments on the post and add an alert at the top to say that the linked comment doesn't exist

Yep that's what I'm describing in the issue description.

[timothyis]

Yep that's what I'm describing in the issue description.

Wasn't clear to me that your were describing loading all the comments, rather than just showing a "not found" message

[tom-sherman]

Realised this is slightly more difficult than I thought. I thought that we could just implement custom not-found.tsx.

not-found.tsx doesn't receive the params as props so it's not possible to customise the content on the server based on the url. This will only work for posts, not comments. For comments we'll need to change the data layer to not use notFound(), instead it should return null to be handled by the component. This also means we won't be sending a 404, so we'll need to ensure the page isn't indexed.