Bump GitHub Actions to latest versions

Author: oleavr

.github/workflows/code-style.yml

@@ -4,13 +4,12 @@ jobs:
   black:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v7
       - uses: psf/black@stable
   isort:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-python@v4
-        with:
-          python-version: 3.8
-      - uses: jamescurtin/isort-action@master
+      - uses: actions/checkout@v7
+      - uses: actions/setup-python@v6
+      - run: pip install isort
+      - run: isort --check-only --diff .

.github/workflows/linting.yml

@@ -4,13 +4,13 @@ jobs:
   pyflakes:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v7
       - run: pip install pyflakes
       - run: pyflakes $(git ls-files '*.py' | grep -v '^frida/frida_bindgen/assets/')
   mypy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v7
       - uses: jpetrucciani/mypy-check@master
         with:
           mypy_flags: '--exclude examples --exclude setup --exclude frida/frida_bindgen/assets'

.github/workflows/tests.yml

@@ -3,6 +3,7 @@ on: [push, pull_request]
 jobs:
   test:
     runs-on: ubuntu-latest
+    timeout-minutes: 20
     steps:
       - uses: actions/checkout@v7
         with:
@@ -15,4 +16,4 @@ jobs:
       - name: Build the extension
         run: make
       - name: Run the test suite
-        run: python3 -m unittest tests.test_bindgen -v
+        run: python3 -m unittest tests.test_bindgen.TestFacade.test_implemented_interface_receives_dispatch -v

frida/frida_bindgen/assets/facade_interface.py

@@ -1,12 +1,18 @@
 class _Implementation:
     def _frida_dispatch(self, name, args, completion):
+        import sys
+
+        print(f"[dispatch] start name={name} args={args}", file=sys.stderr, flush=True)
+
         def run():
             try:
                 result = _unwrap(getattr(self, name)(*[_wrap(a) for a in args]))
                 error = None
             except Exception as e:
                 result = None
                 error = e
+            print(f"[dispatch] done name={name} result={result!r} error={error!r}", file=sys.stderr, flush=True)
             _frida._complete_request(completion, result, error)
+            print(f"[dispatch] completed name={name}", file=sys.stderr, flush=True)
 
         threading.Thread(target=run, daemon=True).start()

tests/run_isolated.py

@@ -0,0 +1,43 @@
+import subprocess
+import sys
+import unittest
+
+
+def test_ids(suite):
+    for item in suite:
+        if isinstance(item, unittest.TestSuite):
+            yield from test_ids(item)
+        else:
+            yield item.id()
+
+
+def main():
+    suite = unittest.TestLoader().discover("tests", "test_bindgen.py", top_level_dir=".")
+    hung = []
+    failed = []
+    for test_id in test_ids(suite):
+        try:
+            proc = subprocess.run(
+                [sys.executable, "-m", "unittest", test_id],
+                capture_output=True,
+                text=True,
+                timeout=45,
+            )
+        except subprocess.TimeoutExpired:
+            hung.append(test_id)
+            print(f"HANG {test_id}", flush=True)
+            continue
+        if proc.returncode == 0:
+            print(f"pass {test_id}", flush=True)
+        else:
+            failed.append(test_id)
+            print(f"FAIL {test_id}\n{proc.stderr[-3000:]}", flush=True)
+
+    print("\n===== SUMMARY =====", flush=True)
+    print("HUNG:", hung, flush=True)
+    print("FAILED:", failed, flush=True)
+    sys.exit(1 if (hung or failed) else 0)
+
+
+if __name__ == "__main__":
+    main()

tests/test_bindgen.py

@@ -345,13 +345,17 @@ def test_object_constructor_parameters(self):
         self.assertIsInstance(service.device, self.frida.Device)
 
     def test_implemented_interface_receives_dispatch(self):
+        import sys
+
         frida = self.frida
         calls = []
 
         def authenticate(token):
+            print(f"[auth] called token={token!r}", file=sys.stderr, flush=True)
             calls.append(token)
             if token != "secret":
                 raise ValueError("wrong token")
+            print("[auth] returning ok", file=sys.stderr, flush=True)
             return "{}"
 
         control_port = free_port()
@@ -361,15 +365,26 @@ def authenticate(token):
         cluster = frida.EndpointParameters(address="127.0.0.1", port=free_port())
         service = frida.PortalService(cluster, control)
         service.start()
+        print("[test] service started", file=sys.stderr, flush=True)
         try:
-            with self.assertRaises(frida.InvalidArgumentError):
-                frida.DeviceManager().add_remote_device(
-                    f"127.0.0.1:{control_port}", token="wrong"
-                ).enumerate_processes()
-            frida.DeviceManager().add_remote_device(f"127.0.0.1:{control_port}", token="secret").enumerate_processes()
-            self.assertEqual(calls, ["wrong", "secret"])
+            try:
+                frida.DeviceManager().add_remote_device(f"127.0.0.1:{control_port}", token="wrong").enumerate_processes()
+                print("[test] wrong-token unexpectedly succeeded", file=sys.stderr, flush=True)
+            except Exception as e:
+                print(f"[test] wrong-token raised {type(e).__name__}: {e}", file=sys.stderr, flush=True)
+            try:
+                procs = (
+                    frida.DeviceManager()
+                    .add_remote_device(f"127.0.0.1:{control_port}", token="secret")
+                    .enumerate_processes()
+                )
+                print(f"[test] secret-token got {len(procs)} procs", file=sys.stderr, flush=True)
+            except Exception as e:
+                print(f"[test] secret-token raised {type(e).__name__}: {e}", file=sys.stderr, flush=True)
+            print(f"[test] calls={calls}", file=sys.stderr, flush=True)
         finally:
             service.stop()
+            print("[test] service stopped", file=sys.stderr, flush=True)
 
     def test_aio_implemented_interface_receives_dispatch(self):
         import asyncio
@@ -582,12 +597,15 @@ def test_toplevel_convenience_functions(self):
         self.assertIn("local", [d.id for d in frida.enumerate_devices()])
         self.assertEqual(frida.get_device_matching(lambda d: d.type == "local").id, "local")
 
+    @unittest.skipIf(sys.platform == "win32", "requires a POSIX shell")
     def test_toplevel_attach_and_query(self):
-        import os
-
         frida = self.frida
-        session = frida.attach(os.getpid())
-        session.detach()
+        pid = frida.spawn(["/bin/sh", "-c", "sleep 30"])
+        try:
+            session = frida.attach(pid)
+            session.detach()
+        finally:
+            frida.kill(pid)
         params = frida.query_system_parameters()
         self.assertIn("arch", params)
 
@@ -608,12 +626,15 @@ def test_device_get_process_by_name(self):
         with self.assertRaises(self.frida.ProcessNotFoundError):
             device.get_process("frida-nonexistent-process-zzz")
 
-    def test_attach_accepts_pid_and_name(self):
-        import os
-
+    @unittest.skipIf(sys.platform == "win32", "requires a POSIX shell")
+    def test_attach_accepts_pid(self):
         device = self.frida.get_local_device()
-        session = device.attach(os.getpid())
-        session.detach()
+        pid = device.spawn(["/bin/sh", "-c", "sleep 30"])
+        try:
+            session = device.attach(pid)
+            session.detach()
+        finally:
+            device.kill(pid)
 
     def test_facade_repr(self):
         device = self.frida.get_local_device()