Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodtables@2 improvements for Laminar #371

Closed
2 tasks done
roll opened this issue Jun 8, 2020 · 3 comments
Closed
2 tasks done

Goodtables@2 improvements for Laminar #371

roll opened this issue Jun 8, 2020 · 3 comments
Labels
general General improvements

Comments

@roll
Copy link
Member

roll commented Jun 8, 2020

Overview

While v3 will be in a pre-release state for some time we'd like to backport everything that are needed for Laminar right now in the v2.

Tasks

@roll
Copy link
Member Author

roll commented Jun 8, 2020

Hi @cschloer,

have I missed something?

@roll roll added the general General improvements label Jun 8, 2020
@roll
Copy link
Member Author

roll commented Jun 12, 2020

Hi @cschloer,

I've created a hook for [email protected] to support head/body checks for the same class:

def test_validate_wide_table_with_order_fields_issue_368(log):
    @check('custom-check', type='custom', context='body')
    class CustomCheck(object):
        def __init__(self, *args, **kwargs):
            pass

        def check_headers_hook(self, cells, sample):
            errors = []
            errors.append(Error('custom-check-head'))
            return errors

        def check_row(self, cells):
            errors = []
            errors.append(Error('custom-check-body'))
            return errors

    report = validate([['header'], ['value']], checks=['custom-check'])
    assert log(report) == [
        (1, None, None, 'custom-check-head'),
        (1, None, None, 'custom-check-body'),
    ]

@roll
Copy link
Member Author

roll commented Jun 12, 2020

@cschloer,

I've created an issue for dataflows regarding goodtables - datahq/dataflows#142

@roll roll closed this as completed Jun 12, 2020
@roll roll moved this to Done in Open Knowledge Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general General improvements
Projects
Archived in project
Development

No branches or pull requests

1 participant