Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide helpful error messages when ImageMagick's convert isn't present #11

Open
voutilad opened this issue Jan 29, 2017 · 0 comments
Open
Assignees

Comments

@voutilad
Copy link

Instead of a traceback when running tests like:

Traceback (most recent call last):
  File "/home/vagrant/seal-rookery/test.py", line 63, in test_can_force_regeneration_of_seals
    changed, skipped = convert_images.convert_images(forced=True)
  File "/home/vagrant/seal-rookery/seal_rookery/convert_images.py", line 84, in convert_images
    subprocess.Popen(command, shell=False).communicate()
  File "/usr/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Or a vague error when running update-seals -f like: [Errno 2] No such file or directory

There should be a more descriptive message suggesting that ImageMagick is not installed or on the current PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant