Don't enable apt-daily services, just the timers #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
force-pushed
the
stg-disable-apt-daily
branch
from
64eab75 to
ff00081
Compare
|
(This isn't on the critical path for noble, so I'll fix it up later.) |
legoktm
force-pushed
the
stg-disable-apt-daily
branch
2 times, most recently
from
41f7496 to
b2d6ebe
Compare
By enabling the services, it means it runs every time the machine boots, defeating the point of the timer. Similarly, starting the service/timer means that it starts running while the playbook is still going, which might also explain the dpkg lock contention (#7258). Ansible will now just ensure the units are unmasked and the securedrop-config postinst will disable the services if enabled. Fixes #7298
legoktm
force-pushed
the
stg-disable-apt-daily
branch
from
b2d6ebe to
3730228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
By enabling the services, it means it runs every time the machine boots, defeating the point of the timer.
Similarly, starting the service/timer means that it starts running while the playbook is still going, which might also explain the dpkg lock contention (#7258).
Ansible will now just ensure the units are unmasked and the securedrop-config postinst will disable the services if enabled.
Fixes #7298.
Testing
How should the reviewer test this PR?
Deployment
Checklist