Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install grub2-xen-pvh in dom0 using rpm dependencies instead of manually #1063

Open
1 task done
legoktm opened this issue Jun 5, 2024 · 1 comment · May be fixed by #1211
Open
1 task done

Install grub2-xen-pvh in dom0 using rpm dependencies instead of manually #1063

legoktm opened this issue Jun 5, 2024 · 1 comment · May be fixed by #1211
Milestone
1.1.0

Comments

@legoktm
Copy link
Member

legoktm commented Jun 5, 2024

  • I have searched for duplicates or related issues

Description

securedrop-workstation/files/sdw-admin.py

Lines 66 to 74 in 6627451

def install_pvh_support():
"""
Installs grub2-xen-pvh in dom0 - required for PVH with AppVM local kernels
TODO: install this via package requirements instead if possible
"""
try:
subprocess.check_call(["sudo", "qubes-dom0-update", "-y", "-q", "grub2-xen-pvh"])
except subprocess.CalledProcessError:
raise SDWAdminException("Error installing grub2-xen-pvh: local PVH not available.")

The problem is that we install the rpm using dnf manually so it can't install any dependencies. See further discussion on #986.
@rocodes rocodes added this to the 1.1.0 milestone Dec 3, 2024
@rocodes
Copy link
Contributor

rocodes commented Dec 3, 2024

@legoktm: Now that we're moving towards a keyring boostrap rpm, I think we can revisit this, since as a precondition to the dom0 config rpm, the boostrap rpm with our repo file will be in place and we can sudo qubes-dom0-update securedrop-workstation-dom0-config as the config rpm installation path. I've added this to the milestone, mostly so we remember to talk about it, but if what I've laid out makes sense, I'll put up a PR.

@rocodes rocodes linked a pull request Dec 3, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Make grub2-xen-pvh a dependency of dom0 config rpm freedomofpress/securedrop-workstation
2 participants
@legoktm @rocodes