Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS development setup doesn't work without x86_64 Homebrew #2333

Open
tomkins opened this issue Dec 14, 2024 · 0 comments · May be fixed by #2334
Open

macOS development setup doesn't work without x86_64 Homebrew #2333

tomkins opened this issue Dec 14, 2024 · 0 comments · May be fixed by #2334

Comments

@tomkins
Copy link

tomkins commented Dec 14, 2024

Description

Following on from #1591 and #1603, testing the client under macOS requires a separate version of Homebrew.

As it's close to 2025, it's a lot easier to run nearly all software under arm64 Homebrew and not need a separate x86_64 installation. So - it might be good to add support for Apple Silicon.

Steps to Reproduce

Setup the development environment without x86_64 Homebrew.

Expected Behavior

To be able to poetry install without errors, and run.sh without errors.

Actual Behavior

PyQt5 fails to install:

  RuntimeError

  Unable to find installation candidates for pyqt5-qt5 (5.15.2)

  at ~/.virtualenvs/securedrop-client/lib/python3.11/site-packages/poetry/installation/chooser.py:74 in choose_for
       70│
       71│             links.append(link)
       72│
       73│         if not links:
    →  74│             raise RuntimeError(f"Unable to find installation candidates for {package}")
       75│
       76│         # Get the best link
       77│         chosen = max(links, key=lambda link: self._sort_key(package, link))
       78│

Cannot install pyqt5-qt5.

And if you do install another version of PyQt5 that does work, then the run script also causes an issue:

$ ./run.sh
...
Current OS is *not* Qubes, disabling DispVM support...
Starting client, home directory: /Users/tomkins/.sdc_tmp/sd_client.CByR
arch: posix_spawnp: poetry: Bad CPU type in executable

Comments

Will follow up with a pull request shortly.
@tomkins tomkins linked a pull request Dec 14, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update macOS support to run on arm64 tomkins/securedrop-client
1 participant
@tomkins