Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress non-actionable (sys/sd)-whonix messages #2277

Open
1 task done
deeplow opened this issue Oct 1, 2024 · 4 comments · May be fixed by #2278
Open
1 task done

Supress non-actionable (sys/sd)-whonix messages #2277

deeplow opened this issue Oct 1, 2024 · 4 comments · May be fixed by #2278
Assignees
Labels

Comments

@deeplow
Copy link
Contributor

deeplow commented Oct 1, 2024

  • I have searched for duplicates or related issues

Description

Whonix is quite verbose and sometimes information is not important at all. One specific example, which is complicating automated testing is when whonix shows a dialog just to inform that some repo is enabled. This is unnecessary.

Steps to Reproduce

Install workstation on a clean Qubes system.

Expected Behavior

No unactionable information is shown to the user.

Actual Behavior

Screenshot 2024-10-01 at 12-10-12 Qubes OS openQA qubesos-4 2-update-x86_64-Builddeeplow_openqa-tests-qubesos_25-system_tests_securedrop@64bit test results

Comments

This may end up being an upstream "issue", but if there is anyway we can suppress this, it would be a very nice addition.

@deeplow deeplow added the ux label Oct 1, 2024
@deeplow
Copy link
Contributor Author

deeplow commented Oct 18, 2024

Turns out we can (and probably should) hide these messages via a config file in /etc/systemcheck.d/. Something like this would suppress all systemcheck non-actionable messages (for SD users):

systemcheck_skip_functions+=" check_apt_repository"   # Skip info about enabled derivative repository
systemcheck_skip_functions+=" check_operating_system" # Skip OS updates check (already ensured in SD updater)
systemcheck_skip_functions+=" donate"

One thing to consider, though, is that because we're installing it in whonix-gateway-17, sys-whonix may end up also being affected.

@deeplow deeplow transferred this issue from freedomofpress/securedrop-workstation Nov 4, 2024
@deeplow deeplow linked a pull request Nov 4, 2024 that will close this issue
18 tasks
@deeplow deeplow self-assigned this Nov 5, 2024
@deeplow
Copy link
Contributor Author

deeplow commented Nov 5, 2024

Somehow I came across a double-popup. Not sure how to reproduce / what caused it, though.

Screenshot 2024-11-05 at 16-43-10 Qubes OS openQA qubesos-4 2-update-x86_64-Builddeeplow_openqa-tests-qubesos_25-system_tests_securedrop@64bit test results

@deeplow
Copy link
Contributor Author

deeplow commented Nov 8, 2024

Found another instance where it only mentions the derivative repository, but not donate button and the update check. And this time it showed as the system booted up for the first time and not when doing the sys-whonix configuartion step.

Screenshot 2024-11-08 at 10-39-42 Qubes OS openQA qubesos-4 2-securedrop-x86_64-Build2024110810-4 2-securedrop_install@64bit test results

@deeplow
Copy link
Contributor Author

deeplow commented Nov 26, 2024

For the time being I've been able find a way to suppress these messages without needing to remove the dialogs in QA, but it waits ~300s trying to dismiss a potential prompt which may choose not to pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Cycle Backlog
Development

Successfully merging a pull request may close this issue.

1 participant