Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run our large test suite in GitHub Actions #969

Open
apyrgio opened this issue Oct 23, 2024 · 0 comments
Open

Run our large test suite in GitHub Actions #969

apyrgio opened this issue Oct 23, 2024 · 0 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@apyrgio
Copy link
Contributor

apyrgio commented Oct 23, 2024

What is the feature you think should be a good addition to Dangerzone?

Dangerzone has a test suite with a large number of documents, that we tend to run before each release. We usually run this locally, but it takes quite a lot of time and space. It would be best to run it in GitHub Actions. The test suite is documented here: https://github.com/freedomofpress/dangerzone/blob/main/docs/developer/TESTING.md

Is your feature request related to a problem? Please describe.

This test suite is useful for detecting regressions in our code, so it's good to run it in regular intervals.

Additional context

Anecdotally, running this test suite locally takes about a day. On the other hand, GitHub's Usage Limits state that jobs can run for a maximum of 6 hours:

Job execution time - Each job in a workflow can run for up to 6 hours of execution time. If a job reaches this limit, the job is terminated and fails to complete.

Luckily, GitHub allows us to run 20 concurrent jobs in our free plan. There are people who have taken advantage of this fact to parallelize their pytest invocations: https://github.com/jerry-git/pytest-split-gh-actions-demo/blob/master/.github/workflows/test.yml

See also:

@apyrgio apyrgio added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

1 participant