You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
System: macOS 10.13.1
Safari: 11.0.1 (but is not exclusive to this version)
I am on a german keyboard and cmd+< is a macOS system-wide shortcut to switch between windows of the current app. On Chrome and Firefox, this works as expected, but in Safari, Devdocs seems to listen for this shortcut, which opens the settings page.
The shortcut from the document (strg+,) also works, so the extra shortcut is not needed and removing it would result in the expected behavior of the browser.
The text was updated successfully, but these errors were encountered:
The reason this is happening is because both < and , return 188 from event.which.
With an English keyboard layout, this is not a problem, because you can get the difference by checking if the shift key is pressed, but on the German keyboard layout, both characters have different keys.
As far as I can see, the only way to get around it is to use event.key instead of event.which in handleKeyDownSuperEvent That way you get the actual character instead of the problematic keyCodes.
I have created a pull request with those changes: #724
System: macOS 10.13.1
Safari: 11.0.1 (but is not exclusive to this version)
I am on a german keyboard and
cmd+<
is a macOS system-wide shortcut to switch between windows of the current app. On Chrome and Firefox, this works as expected, but in Safari, Devdocs seems to listen for this shortcut, which opens the settings page.The shortcut from the document (
strg+,
) also works, so the extra shortcut is not needed and removing it would result in the expected behavior of the browser.The text was updated successfully, but these errors were encountered: