Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] CMD+< shortcut opens settings page #723

Open
hpohlmeyer opened this issue Nov 23, 2017 · 1 comment
Open

[Safari] CMD+< shortcut opens settings page #723

hpohlmeyer opened this issue Nov 23, 2017 · 1 comment
Labels

Comments

@hpohlmeyer
Copy link

System: macOS 10.13.1
Safari: 11.0.1 (but is not exclusive to this version)

I am on a german keyboard and cmd+< is a macOS system-wide shortcut to switch between windows of the current app. On Chrome and Firefox, this works as expected, but in Safari, Devdocs seems to listen for this shortcut, which opens the settings page.

The shortcut from the document (strg+,) also works, so the extra shortcut is not needed and removing it would result in the expected behavior of the browser.

@hpohlmeyer
Copy link
Author

hpohlmeyer commented Nov 23, 2017

I dug a little further into this.

The reason this is happening is because both < and , return 188 from event.which.
With an English keyboard layout, this is not a problem, because you can get the difference by checking if the shift key is pressed, but on the German keyboard layout, both characters have different keys.

As far as I can see, the only way to get around it is to use event.key instead of event.which in handleKeyDownSuperEvent That way you get the actual character instead of the problematic keyCodes.

I have created a pull request with those changes: #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants