Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sidebar styling #668

Open
Svenskunganka opened this issue Sep 6, 2017 · 3 comments
Open

Improve sidebar styling #668

Svenskunganka opened this issue Sep 6, 2017 · 3 comments

Comments

@Svenskunganka
Copy link

Svenskunganka commented Sep 6, 2017

I feel like the sidebar could give mouse users better feedback with some cursor changes and hover color. Here's what I propose:

  • Remove __.list-item's cursor: default (this line) to set it back to auto (which will be cursor: pointer on most browsers). Currently only the arrow provides feedback that the element is clickable.
  • Add a :hover background color for .list_item:
    .__list-item:hover {
      background-color: #e3e3e3;
    }
Current New
@agatac
Copy link

agatac commented Oct 18, 2017

Is this issue unassigned? I could help and pick it up.

@Thibaut
Copy link
Member

Thibaut commented Oct 19, 2017

Hey - sorry for the delay. This is on my list of things to look into, but I haven't had time yet.

The current styling is intentional. I felt that not having hover effects gave the app a more desktop-feel, works better on touch devices, and because the highlight background is also used for the focus state, and things get confusing when both hover and focus are active on two different rows at the same time.

That said, I'm all for improving the UI, so was planning to experiment with this issue/feedback next time I work on UI changes.

@agatac if you'd like to give this a try and submit a PR, you're very welcome to, but just a heads up that I can't guarantee I would accept your changes, as I'm not sure yet exactly how I'd like this issue to be addressed.

@agatac
Copy link

agatac commented Oct 19, 2017

Alright, I'll leave it up to you then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants