Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make offline storage persistent #703

Open
brianchirls opened this issue Oct 24, 2017 · 5 comments · May be fixed by #1274
Open

Add option to make offline storage persistent #703

brianchirls opened this issue Oct 24, 2017 · 5 comments · May be fixed by #1274
Labels

Comments

@brianchirls
Copy link

Thanks for this awesome site. I missed it terribly this week when I was traveling with a bad or no internet connection and Chrome bumped it from my cache.

Please consider using StorageManager so we can optionally make storage persistent. Thanks.

@Thibaut
Copy link
Member

Thibaut commented Oct 29, 2017

Sorry to hear that :/ I'm eagerly waiting for the Storage API to be implemented in all browsers, so we can do away with all the persistent storage issues.

Before working on this I'd like to see at least one other browser (Firefox) ship the API, and I also need to complete the migration over to HTTPS (Chrome only enables navigator.storage in secure contexts), which is a tricky beast because IndexedDB data is per-origin (i.e. not shared between HTTP and HTTPS), so users will need to migrate their data. Once this done, this feature will be top of my list.

@hexpunk
Copy link

hexpunk commented Oct 29, 2017

@Thibaut I thought devdocs was already https-enabled? #446

I just switched from http to https and it kept all my settings. 😕

@Thibaut
Copy link
Member

Thibaut commented Oct 30, 2017

@jayandcatchfire While DevDocs works over HTTPS, HTTP is still the default (one reason being that until #633, many docs had insecure assets/images which wouldn't load over HTTPS) . Most people use the HTTP version.

Before implementing persistent storage, I want to force HTTPS, so that the feature is available to everyone. However, forcing HTTPS will nuke all HTTP users' offline data (but not their settings—like you said), so before doing that I need to implement a few things to let the users know and ease the transition.

@Kaijiro
Copy link

Kaijiro commented Oct 30, 2017

About the HTTP => HTTPS migration in order to minimize data loss for users I think (once HTTPS is ready to deploy of course) there should be a big notice displayed warning them that due to protocol migration, there data will be lost.
We should guide them with an export / import procedure to help them. Maybe should we discuss this point in an other issue ?

@graingert
Copy link

@Kaijiro I've made a ticket about that: #823

pwnall added a commit to pwnall/devdocs that referenced this issue Sep 14, 2020
pwnall added a commit to pwnall/devdocs that referenced this issue Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants