Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Calendar API error handling #2374

Open
ojeytonwilliams opened this issue Feb 14, 2023 · 1 comment
Open

Calendar API error handling #2374

ojeytonwilliams opened this issue Feb 14, 2023 · 1 comment
Labels
API Discussion Ideas, feature requests, views on features. Anything which is a discussion. Email

Comments

@ojeytonwilliams
Copy link
Contributor

Discuss your ideas or share your views:

I was thinking a little more about the conversation I had with @gikf in #2292 (comment) and the changes in #2354

It seems there are three concerns, in rough order of importance

  1. Error handling, particularly rate limits Google Calendar rate limits #2373
  2. Communicating to the user when they need to (re)authenticate and when the service is not available
  3. Avoiding useless requests to external APIs

1 and 2 are quite tightly coupled, since some errors will be caused by a lack of authentication.

3. can matter, since extra requests are wasteful and could push us over rate-limits. However, 1. and 2. seem crucial because otherwise the app could be broken and not give any sign to users.

With that in mind, it makes sense to set up the error handling + communication about those errors to the user first.

The key thing is that whatever we do needs to keep #2373 in mind, since rate limits seem to be the most likely source of errors.

Sorry this is a little nebulous: I wanted to make sure the decision making happened publicly and I have not refined my thinking about this yet.

@ojeytonwilliams ojeytonwilliams added Discussion Ideas, feature requests, views on features. Anything which is a discussion. API Email labels Feb 14, 2023
@allella
Copy link
Contributor

allella commented Feb 14, 2023

Shared thoughts on #2373 (comment) that are mostly the same for this thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Discussion Ideas, feature requests, views on features. Anything which is a discussion. Email
Projects
None yet
Development

No branches or pull requests

2 participants