Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remarks about hints/solutions #45

Open
fuero opened this issue Nov 26, 2021 · 0 comments
Open

Remarks about hints/solutions #45

fuero opened this issue Nov 26, 2021 · 0 comments

Comments

@fuero
Copy link

fuero commented Nov 26, 2021

Hi,

great job with this project!

I've walked through the exercises today, and I'd like to give my € 0.02 about the tips and solutions:

  • On pick-your-features I'd have opted for git merge --squash rather than git cherry-pick - Introducing cherry-pick to the newly-initiated might be a bad idea.
  • For find-swearwords I'd suggest
git log -G '\bshit\b' --all-match
# jot down the revisions
git rebase -
# Search for the revisions, mark them as 'edit'
# Repeat for all revisions:
# Replace the bad word with good word (e.g. sed -i -e 's/^bad$/good/g words.txt)
git add *.txt
git commit --amend
git rebase --continue
  • For find-bug I'd point users to writing a dedicated shell script rather than doing it inline - quoting issues can make things annoying very quickly.

Thanks again for the fun challenge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant