Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

feat: Print plugin location when updating plugin #5

Merged
merged 2 commits into from
Sep 8, 2023
Merged

feat: Print plugin location when updating plugin #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2435a46
feat: Print plugin location when updating plugin
edvardsanta Sep 8, 2023
ea8498a
Merge branch 'main' into hyperupcall-print
hyperupcall Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/functions/plugins.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ update_plugin() {
local prev_ref=
local post_ref=
{
printf "Location of %s plugin: %s\n" "$plugin_name" "$plugin_path"
asdf_run_hook "pre_asdf_plugin_update" "$plugin_name"
asdf_run_hook "pre_asdf_plugin_update_${plugin_name}"

Expand Down
13 changes: 11 additions & 2 deletions test/plugin_update_command.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ EOM
new_ref="$(git --git-dir "$plugin_path/.git" --work-tree "$plugin_path" rev-parse --short HEAD)"

local expected_output="plugin updated path=${plugin_path} old git-ref=${old_ref} new git-ref=${new_ref}"
[[ "$output" = "UPDATE dummy"*"${expected_output}" ]]
[[ "$output" = *"UPDATE dummy"*"${expected_output}" ]]
}

@test "asdf plugin-update executes configured pre hook (specific)" {
Expand All @@ -185,7 +185,7 @@ EOM
new_ref="$(git --git-dir "$plugin_path/.git" --work-tree "$plugin_path" rev-parse --short HEAD)"

local expected_output="plugin updated path=${plugin_path} old git-ref=${old_ref} new git-ref=${new_ref}"
[[ "$output" = "UPDATE"*"${expected_output}" ]]
[[ "$output" = *"UPDATE"*"${expected_output}" ]]
}

@test "asdf plugin-update executes configured post hook (generic)" {
Expand Down Expand Up @@ -222,6 +222,15 @@ UPDATE"
[[ "$output" = *"${expected_output}" ]]
}

@test "asdf plugin-update prints the location of plugin (specific)" {
local plugin_path
plugin_path="$(get_plugin_path dummy)"
run asdf plugin-update dummy

local expected_output="Location of dummy plugin: $plugin_path"
[[ "$output" == *"$expected_output"* ]]
}

@test "asdf plugin-update prints help if --help is passed" {
run asdf plugin update --help
[ "$status" -eq 0 ]
Expand Down